scientific-witchery/pds-dash
3
0
Fork 0
Code Issues 1 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

Fix users with no profile record not being shown #7

Open
astra wants to merge 3 commits from kc/profileless-users-not-being-shown into main
pull from: kc/profileless-users-not-being-shown
merge into: scientific-witchery:main
Conversation 1 Commits 3 Files changed 2 +28 -13
2 changed files with 28 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/lib/AccountComponent.svelte
View file

@ -12,10 +12,14 @@
alt="avatar of {account.displayName}"
src="{Config.PDS_URL}/xrpc/com.atproto.sync.getBlob?did={account.did}&cid={account.avatarCid}"
/>
<div id="accountName">
{account.displayName || account.handle || account.did}
</div>
{:else}
<div id="accountName" class="no-avatar">
{account.displayName || account.handle || account.did}
astra commented 2025-05-14 12:54:32 +00:00
Copy link

Idk about the styling change, needs a further discussion (prolly as part of a bigger config update)

Idk about the styling change, needs a further discussion (prolly as part of a bigger config update)
kc commented 2025-05-15 11:07:02 +00:00
Copy link

In the chat you said that it'd be better to not align avatarless users and keep them small, should I do that now?

In the chat you said that it'd be better to not align avatarless users and keep them small, should I do that now?
</div>
{/if}
<div id="accountName">
{account.displayName || account.handle || account.did}
</div>
</div>
</a>
@ -28,6 +32,7 @@
padding: 0px;
margin-bottom: 15px;
border: 1px solid var(--border-color);
min-height: 50px;
}
#accountName {
margin-left: 10px;
@ -39,6 +44,9 @@
text-overflow: ellipsis;
white-space: nowrap;
}
.no-avatar {
margin-left: 60px !important;
}
#avatar {
width: 50px;
height: 50px;

27
src/lib/pdsfetch.ts
View file

@ -132,7 +132,13 @@ const getDidsFromPDS = async (): Promise<At.Did[]> => {
const getAccountMetadata = async (
did: `did:${string}:${string}`,
) => {
// gonna assume self exists in the app.bsky.actor.profile
const account: AccountMetadata = {
kc marked this conversation as resolved Outdated
astra commented 2025-05-14 12:53:25 +00:00
Outdated
Copy link

Is this comment still valid?

Is this comment still valid?
kc commented 2025-05-15 11:04:44 +00:00
Outdated
Copy link

No, not really. I forgot to remove it, sorry!
I'll clean up some things a bit now

No, not really. I forgot to remove it, sorry! I'll clean up some things a bit now
did: did,
handle: "", // Guaranteed to be filled out later
displayName: "",
avatarCid: null,
};
try {
const { data } = await rpc.get("com.atproto.repo.getRecord", {
params: {
@ -142,21 +148,22 @@ const getAccountMetadata = async (
},
});
const value = data.value as AppBskyActorProfile.Record;
const handle = await blueskyHandleFromDid(did);
const account: AccountMetadata = {
did: did,
handle: handle,
displayName: value.displayName || "",
avatarCid: null,
};
account.displayName = value.displayName || "";
if (value.avatar) {
account.avatarCid = value.avatar.ref["$link"];
}
return account;
} catch (e) {
console.error(`Error fetching metadata for ${did}:`, e);
console.warn(`Error fetching profile for ${did}:`, e);
}
try {
account.handle = await blueskyHandleFromDid(did);
} catch (e) {
console.error(`Error fetching handle for ${did}:`, e);
return null;
}
return account;
};
const getAllMetadataFromPds = async (): Promise<AccountMetadata[]> => {