scientific-witchery/pds-dash
3
0
Fork 0
Code Issues 1 Pull requests 1 Projects 1 Releases Packages Wiki Activity Actions

Fix users with no profile record not being shown #7

Open
astra wants to merge 3 commits from kc/profileless-users-not-being-shown into main
pull from: kc/profileless-users-not-being-shown
merge into: scientific-witchery:main
Conversation 1 Commits 3 Files changed 2 +28 -13
astra commented 2025-05-14 12:52:36 +00:00
Owner
Copy link
No description provided.
astra added 2 commits 2025-05-14 12:52:36 +00:00
kc was assigned by astra 2025-05-14 12:52:43 +00:00
astra reviewed 2025-05-14 12:55:08 +00:00
src/lib/AccountComponent.svelte
@ -15,0 +17,4 @@
</div>
{:else}
<div id="accountName" class="no-avatar">
{account.displayName || account.handle || account.did}
astra commented 2025-05-14 12:54:32 +00:00
Author
Owner
Copy link

Idk about the styling change, needs a further discussion (prolly as part of a bigger config update)

Idk about the styling change, needs a further discussion (prolly as part of a bigger config update)
kc commented 2025-05-15 11:07:02 +00:00
Owner
Copy link

In the chat you said that it'd be better to not align avatarless users and keep them small, should I do that now?

In the chat you said that it'd be better to not align avatarless users and keep them small, should I do that now?
src/lib/pdsfetch.ts Outdated
@ -133,6 +133,13 @@ const getAccountMetadata = async (
did: `did:${string}:${string}`,
) => {
// gonna assume self exists in the app.bsky.actor.profile
astra commented 2025-05-14 12:53:25 +00:00
Author
Owner
Copy link

Is this comment still valid?

Is this comment still valid?
kc commented 2025-05-15 11:04:44 +00:00
Owner
Copy link

No, not really. I forgot to remove it, sorry!
I'll clean up some things a bit now

No, not really. I forgot to remove it, sorry! I'll clean up some things a bit now
kc marked this conversation as resolved
kc added 1 commit 2025-05-15 11:14:22 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin kc/profileless-users-not-being-shown:kc/profileless-users-not-being-shown
git checkout kc/profileless-users-not-being-shown

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff kc/profileless-users-not-being-shown
git checkout kc/profileless-users-not-being-shown
git rebase main
git checkout main
git merge --ff-only kc/profileless-users-not-being-shown
git checkout kc/profileless-users-not-being-shown
git rebase main
git checkout main
git merge --no-ff kc/profileless-users-not-being-shown
git checkout main
git merge --squash kc/profileless-users-not-being-shown
git checkout main
git merge --ff-only kc/profileless-users-not-being-shown
git checkout main
git merge kc/profileless-users-not-being-shown
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
kc
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: scientific-witchery/pds-dash#7
No description provided.
Delete branch "kc/profileless-users-not-being-shown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?